Skip to content

fix: stdlib remove some overloads#284

Merged
CppCXY merged 1 commit into
EmmyLuaLs:mainfrom
lewis6991:fix/stdoverlo
Mar 27, 2025
Merged

fix: stdlib remove some overloads#284
CppCXY merged 1 commit into
EmmyLuaLs:mainfrom
lewis6991:fix/stdoverlo

Conversation

@lewis6991
Copy link
Copy Markdown
Collaborator

Not sure why these were added, but they shouldn't be necessary.

Not sure why these were added, but they shouldn't be necessary.
@xuhuanzy
Copy link
Copy Markdown
Member

This is a case of "the ancestral laws must not be altered" (a historical legacy issue). The old version of emmylua had effectively ceased maintenance long ago (the original author stopped updating it), and these std definitions have long been outdated.

Although it's still called emmylua now, the core is entirely different. In fact, I'm quite puzzled as to why the project continues to bear the name emmylua.

@lewis6991
Copy link
Copy Markdown
Collaborator Author

I agree about the name, especially since this project supports LuaCATS and not EmmyLua

@CppCXY
Copy link
Copy Markdown
Member

CppCXY commented Mar 27, 2025

Because I was an member of EmmyLua and the early version of this project was implemented in C#, the name was inherited

@CppCXY CppCXY merged commit 323cce7 into EmmyLuaLs:main Mar 27, 2025
14 checks passed
@lewis6991 lewis6991 deleted the fix/stdoverlo branch March 27, 2025 12:54
@lewis6991
Copy link
Copy Markdown
Collaborator Author

Would it make sense to change the name?

@CppCXY
Copy link
Copy Markdown
Member

CppCXY commented Mar 27, 2025

which name? I want to keep the name 'emmylua' because 'luals' is already taken, and everyone is very accustomed to this name. Additionally, it is called 'analyzer' because it was originally copied from 'rust-analyzer'.

@lewis6991
Copy link
Copy Markdown
Collaborator Author

emmylua doesn't make sense since this project doesn't support EmmyLua.

Maybe lua_analyzer or luacats_ls?

@CppCXY
Copy link
Copy Markdown
Member

CppCXY commented Mar 27, 2025

emmylua doesn't make sense since this project doesn't support EmmyLua.

Maybe lua_analyzer or luacats_ls?

I can't update this website, so it remains as it is. I kept EmmyLua because it serves as the language server for VSCode EmmyLua. Additionally, I chose to be compatible with the current LuaCATS, but I didn't follow LuaLS 100%. In fact, most of LuaCATS was decided after discussions between Sumneko and me. Our plugins will choose to be syntactically compatible with each

@xuhuanzy
Copy link
Copy Markdown
Member

In fact, the functionality of that plugin is quite primitive and includes some unnecessary features.
Additionally, there are now noticeable differences between the plugin and LuaCATS.

@lewis6991
Copy link
Copy Markdown
Collaborator Author

I can't update this website, so it remains as it is. I kept EmmyLua because it serves as the language server for VSCode EmmyLua.

That is confusing. There seems to be 3 different Lua annotation formats, but only two are documented, and this project doesn't support EmmyLua.

The good thing about LuaLS is that it defines LuaCATS as something separate to EmmyLua with documentation for the annotations. Will you do something similar for this project ("new emmylua")?

Without clear communication, adoption will be difficult.

@xuhuanzy
Copy link
Copy Markdown
Member

The documentation will be provided later, but the foundational work is not yet complete, so providing it now is unnecessary.
Of course, it would be best if new maintainers could join in to help with the documentation.
I recommend using VitePress to build the documentation.

@lewis6991
Copy link
Copy Markdown
Collaborator Author

Basic markdown files within this project would be sufficient for the short term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants